-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dashboards: overview: use native histograms in status #7627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow switching between basing status on classic or native version of cortex_request_duration_seconds. Related to #7154 Signed-off-by: György Krajcsovits <[email protected]>
krajorama
force-pushed
the
krajo/native-overview-status
branch
from
March 20, 2024 09:03
0823bd6
to
58b6ee3
Compare
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
4 tasks
Add in the dashboard so it's always last. Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
krajorama
added a commit
that referenced
this pull request
Mar 21, 2024
Allow using cortex_request_duration_seconds native histogram in overview dashboard everywhere. Followup to #7627 Signed-off-by: György Krajcsovits <[email protected]>
zenador
reviewed
Apr 4, 2024
instead of separate but equal readRequestPerSecondMetric and writeRequestPerSecondMetric Signed-off-by: György Krajcsovits <[email protected]>
Signed-off-by: György Krajcsovits <[email protected]>
krajorama
added a commit
that referenced
this pull request
Apr 5, 2024
Allow using cortex_request_duration_seconds native histogram in overview dashboard everywhere. Followup to #7627 Signed-off-by: György Krajcsovits <[email protected]>
zenador
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
krajorama
added a commit
that referenced
this pull request
Jun 24, 2024
…nds (#7674) * dashboards: overview: use native histograms in status Allow switching between basing status on classic or native version of cortex_request_duration_seconds. Related to #7154 Followup to #7627 Signed-off-by: György Krajcsovits <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Allow switching between basing status on classic or native version of cortex_request_duration_seconds.
Which issue(s) this PR fixes or relates to
Related to #7154
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.